Skip to content

[v20.x backport] lib: suppress source map lookup exceptions #59653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v20.x backport] lib: suppress source map lookup exceptions #59653

wants to merge 2 commits into from
+68 −30

Conversation

devjiwonchoi
Copy link

@devjiwonchoi devjiwonchoi commented Aug 27, 2025 •
edited
Loading

Backports #56299 to v20.x.

When bumping v18 to v20, I received the following error from a test fixture with an invalid source-map.

TypeError [ERR_INVALID_ARG_TYPE]: The \"payload\" argument must be of type object. Received null
  at cloneSourceMapV3 (node:internal/source_map/source_map:365:3)
  at new SourceMap (node:internal/source_map/source_map:145:21)
  at findSourceMap (node:internal/source_map/source_map_cache:352:17)
  at filterStackFrameDEV (file:///Users/devjiwonchoi/code/work/next.js/packages/
  next/dist/compiled/next-server/app-page.runtime.dev.js:23:10359)

Found PR #56299 skips parsing invalid sourcemap, which will suppress this error, was backported to v22.14.0 and v23.6.0, but was never landed on v20.x.

It received the label backport-requested-v20.x on June 5th, but has not been backported yet. Therefore, opened this backporting PR, hopefully proposing to 20.19.5 'Iron'.

cc @marco-ippolito as whom added the label 🙏

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Aug 27, 2025
@devjiwonchoi devjiwonchoi marked this pull request as ready for review August 27, 2025 20:09
@devjiwonchoi devjiwonchoi mentioned this pull request Aug 27, 2025
Open
@marco-ippolito
Copy link
Member

the [v20.x backport] should not be added in the commit message, we already include some metadata when landing

@devjiwonchoi
Copy link
Author

the [v20.x backport] should not be added in the commit message, we already include some metadata when landing

Got it, removed.

@aduh95
Copy link
Contributor

aduh95 commented Aug 29, 2025 •
edited
Loading

The commit message is different from the one for 28557ef, e.g. the PR-URL is not a URL. Also a33ec12 backport is missing. Let me push a fix for you

@aduh95 aduh95 force-pushed the backport-56299-to-20 branch from 12bcd81 to fb18c72 Compare August 29, 2025 11:08
@legendecas @aduh95
lib: suppress source map lookup exceptions
6e26c73 
When the source map data are invalid json strings, skip construct
`SourceMap` on it. Additionally, suppress exceptions on source map
lookups and fix test runners crash on invalid source maps.

PR-URL: nodejs#56299
Refs: nodejs#56296
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
@legendecas @aduh95
lib: optimize prepareStackTrace on builtin frames
4c0ad1e 
Only invalidates source map lookup cache when a new source map is found.
This improves when user codes interleave with builtin functions, like
`array.map`.

PR-URL: nodejs#56299
Refs: nodejs#56296
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
@aduh95 aduh95 force-pushed the backport-56299-to-20 branch from fb18c72 to 4c0ad1e Compare August 29, 2025 11:13
@devjiwonchoi
Copy link
Author

The commit message is different from the one for 28557ef, e.g. the PR-URL is not a URL. Also a33ec12 backport is missing. Let me push a fix for you

I see, thanks 🙏

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68980/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68983/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68993/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68994/

@marco-ippolito marco-ippolito mentioned this pull request Sep 2, 2025
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68995/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68997/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69002/

@marco-ippolito
Copy link
Member

osx is failing for unrelated reason, I'm backporting

marco-ippolito pushed a commit that referenced this pull request Sep 2, 2025
@legendecas @marco-ippolito
lib: suppress source map lookup exceptions
99b5a52 
When the source map data are invalid json strings, skip construct
`SourceMap` on it. Additionally, suppress exceptions on source map
lookups and fix test runners crash on invalid source maps.

PR-URL: #56299
Backport-PR-URL: #59653
Refs: #56296
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Sep 2, 2025
@legendecas @marco-ippolito
lib: optimize prepareStackTrace on builtin frames
78f1233 
Only invalidates source map lookup cache when a new source map is found.
This improves when user codes interleave with builtin functions, like
`array.map`.

PR-URL: #56299
Backport-PR-URL: #59653
Refs: #56296
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
@marco-ippolito
Copy link
Member

Landed in 42224ac...78f1233

marco-ippolito pushed a commit that referenced this pull request Sep 2, 2025
@legendecas @marco-ippolito
lib: suppress source map lookup exceptions
cdf9850 
When the source map data are invalid json strings, skip construct
`SourceMap` on it. Additionally, suppress exceptions on source map
lookups and fix test runners crash on invalid source maps.

PR-URL: #56299
Backport-PR-URL: #59653
Refs: #56296
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Sep 2, 2025
@legendecas @marco-ippolito
lib: optimize prepareStackTrace on builtin frames
2f333b6 
Only invalidates source map lookup cache when a new source map is found.
This improves when user codes interleave with builtin functions, like
`array.map`.

PR-URL: #56299
Backport-PR-URL: #59653
Refs: #56296
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devjiwonchoi @nodejs-github-bot @marco-ippolito @aduh95 @legendecas